ci: fix failing Differential ShellCheck workflow - #1121
Closed
jamacku wants to merge 1 commit into
Closed
Conversation
jasonkarns
requested changes
Jul 24, 2026
| name: Test | ||
| on: | ||
| push: | ||
| branches: [ main, v5 ] |
Member
There was a problem hiding this comment.
This doesn't seem to make sense to me. I would expect differential shellcheck to be run on any branch that's pushed, not just two arbitrary configured branches. That's why the branches weren't limited in the push events before.
Member
|
Closing this. differential shellcheck should run on any PR, not just specific base branches. Similarly with pushes. There's no reason it should be limited to an arbitrary set of branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential ShellCheck requires a specified branch in the workflow file. To avoid this error:
This should resolve the issue described in: